Issue-139: Add Music #140
Merged
Issue-139: Add Music #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aying music when starting a new game
…h floor we're on, stop music when we leave game loop
Open
Turtyo
requested changes
Dec 14, 2024
There was a problem hiding this comment.
No issue with the code as is, but I noticed some issues when playing the game:
- There is no sound if I start with something else than a mob fight (in the case I tested, with a dialogue at the start, no music is playing)
- The sound is game is not the same balance as the sound of the original music, it sounds like the music is played stronger on the left than the right ear (mostly noticeable for the area 1 music, but it's present on all musics)
Turtyo
requested changes
Dec 21, 2024
There was a problem hiding this comment.
No problem anymore, apart from the fact I hear the music louder in my left ear than my right ear still.
I think this might be the reason : https://forum.godotengine.org/t/why-is-audio-only-played-from-the-left-earphone/21639
Basically, the 2D audio stream plays sounds relative to the camera, meaning that if we want it to be the same on both ears, we need to instantiate the AudioManager at the center of the screen.
I have two ideas for that:
- either see if you can move the 2D audio stream with code from the AudioManager
- if that's not possible, then create an instance of the AudioManager (ie a scene with the script of the AudioManager) and move it from there
I think the first solution would be better, as it's less heavy
Closed
# Conflicts: # #Scenes/SceneScripts/ShopScene.gd # Global/Global_Enums.gd # project.godot
Turtyo
approved these changes
Dec 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add music and SFX to game
Related issue(s)
#139
List of changes
Added the following tracks
Other changes:
Tests
N/A
Additional notes
N/A